knpuniversity / oauth2-client-bundle

Easily talk to an OAuth2 server for social functionality in Symfony
https://symfonycasts.com
MIT License
787 stars 145 forks source link

Keycloak optional config "version" raise cache error if not provided #392

Closed Zuulka closed 1 year ago

Zuulka commented 1 year ago

Hey there,

Since a recent update, (2.13) I noticed that a "version" configuration option is now added for Keycloak. Even if it is qualified as "optional" in your documentation, omitting it raise an error while clearing the cache :

2.13 changelog : https://github.com/knpuniversity/oauth2-client-bundle/releases/tag/v2.13.0

Documentation :

keycloak: [...]

Optional: The keycloak version to run against

       # version: '20.0.1'

$ php bin/console c:c

In KeycloakProviderConfigurator.php line 60:

Warning: Undefined array key "version"

bocharsky-bw commented 1 year ago

Thanks for reporting it! I think we forgot to make it null by default, I fixed it in #393

Zuulka commented 1 year ago

Thanks for reporting it! I think we forgot to make it null by default, I fixed it in #393

No problem ! Thanks for the quick fix :)