search

knpuniversity / symfony4

Screencast code, script and tandem bikes behind the "Stellar Development with Symfony 4" tutorial
https://symfonycasts.com/screencast/symfony
Other
79 stars 430 forks source link

Updates DB name to match Code Snippet example #10

Closed tshiamobhuda closed 5 years ago

tshiamobhuda commented 5 years ago

Upon following through with the tutorial i quickly realised that the DB name on the lesson notes doesn't correspond to the Code Snippet provided. I just update the lesson notes to reflect whats on the Snippet. :smile:

bocharsky-bw commented 5 years ago

Hey @tshiamobhuda ,

Thank you for reporting it! Unfortunately, we can't merge this because we want our scripts match videos. In the video Ryan says exactly:

Call the database the_spacebar:

So, probably we should fix it in another spot. Could you tell me where exactly you saw that the DB should be symfony4_space_bar?

Cheers!

bocharsky-bw commented 5 years ago

Ah, I see! You probably mean .env.dist file from downloaded code. Unfortunately, that file is updated with our internal tool, so only our team members can change it. I just made a fix in 2d64164 so I'm closing this PR in favor of this change.

Thank you for reporting this inconsistency!

Cheers!