search

knpwrs / gulp-cheerio

Manipulate HTML and XML files with Cheerio in Gulp.
MIT License
98 stars 13 forks source link

gulp-cheerio fails due to issue with cheerio #13

Closed nevin closed 5 years ago

nevin commented 8 years ago

Due to the update in cheerio version from 0.20.0 to 0.21.0 - this plugin is failing

knpwrs commented 8 years ago

It seems like 0.20.0 is the latest version published? The following works fine for me:

glcd git@github.com:knpwrs/gulp-cheerio.git
npm i
npm test
nevin commented 8 years ago

It was not. There was a release 0.21.0 and they reverted it after a day due to the issue.

nevin commented 8 years ago

I raised the request when before reverting and u checked it after reverting so its working for u

TomMalufe commented 8 years ago

This issue has been driving me crazy for the past 24 hours. I'm glad I'm not the only one who was experiencing it. Reverting back to cheerio@0.20.0 worked for me.

knpwrs commented 8 years ago

Is this currently an issue? 0.20.0 is still the most recent published version on npm.

TomMalufe commented 8 years ago

I'm not really sure how npm works and how you publish new versions, however the version in package.json is 0.21.0 and I'm guessing that is why npm is still grabbing that version when I install. I had to delete cheerio from my node_modules and run npm install cheerio@0.20.0 to solve my issue.

knpwrs commented 8 years ago

The version on NPM is still 0.20.0:

image

You have to manually publish new versions to NPM. NPM will only install from Github if you tell it to.

TomMalufe commented 8 years ago

All I know is that if I run npm install gulp-cheerio in a clean directory then run npm list | grep cheerio it prints └─┬ gulp-cheerio@0.6.2 ├─┬ cheerio@0.21.0

However, I do have my npm registry set to our company's private registry. Do you think that could be causing me to grab the wrong version?

caillou commented 5 years ago

@nevin do you still experience the problem with 0.22.0? Else I would recommend to close the issue.

nevin commented 5 years ago

Please close the issue

On Fri, Oct 18, 2019, 10:25 PM Pierre Spring notifications@github.com wrote:

@nevin https://github.com/nevin do you still experience the problem with 0.22.0? Else I would recommend to close the issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/knpwrs/gulp-cheerio/issues/13?email_source=notifications&email_token=AABQ2W43MXFS3DEIE5RSJ6DQPHTAHA5CNFSM4CGQELWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBVEE4Q#issuecomment-543834738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQ2WYCK2SIYN4GOKVZSM3QPHTAHANCNFSM4CGQELWA .