knpwrs / gulp-spawn-mocha

Runs Mocha as a child process in Gulp.
MIT License
87 stars 20 forks source link

istanbul not working? #36

Closed nikmash closed 8 years ago

nikmash commented 8 years ago

I tried passing in the istanbul: true flag and it seems it's not running istanbul.

knpwrs commented 8 years ago

Can I see some output?

nikmash commented 8 years ago
var gulp = require('gulp-param')(require('gulp'), process.argv);
var plugins = require('gulp-load-plugins')({DEBUG: true});
plugins.mocha = require('gulp-spawn-mocha');

require('./tasks/testing/test-unit')(gulp, options);
module.exports = function(gulp, options) {
    gulp.task('test-unit', function (jenkins, app) {
        app = app;
        options.plugins.env(options.testEnv);
        var reporter = {reporter: 'nyan', istanbul: true};
        if(jenkins){
            reporter = {reporter: 'mocha-tap-reporter', istanbul: true}
        }
        return gulp.src(options.paths.unitTests[app], {read: false})
            .pipe(options.plugins.print())
            .pipe(options.plugins.mocha(reporter))
            .once('end', function(){
                process.exit();
            });
    });
};

Here's how the gulpfile works. I have the gulp task in a different file from the gulpfile itself. Right now the test runner has no issue running but there is no coverage folder generated when the istanbul: true is passed in.

Output:

[13:45:10] Warning: gulp version mismatch:
[13:45:10] Global gulp is 3.9.1
[13:45:10] Local gulp is 3.9.0
[13:45:10] gulp-load-plugins: Debug enabled with options: {"DEBUG":true}
[13:45:10] gulp-load-plugins: 96 plugin(s) found: amorphic amorphic-mandrill amorphic-userman bluebird bower bunyan connect connect-redis death fast-csv fs-extra google-sheets-node-api googleapis handlebars hogan.js html-pdf isarray jsonwebtoken jszip juice knex mailchimp mocha-tap-reporter moment moment-timezone mongodb nconf newrelic node-mandrill node-uuid node-zendesk parseurl persistor pg q q-io request request-promise saml20 ssh2 supertype tmp tv4 underscore validator xlsx xml-crypto xml2js xmldom amqplib async browser-sync bunyan-prettystream chai chai-as-promised copy-dir del es6-promise eslint eslint-stats eslint-watch favicons fs glob gulp gulp-autoprefixer gulp-concat gulp-debug gulp-env gulp-eslint gulp-header gulp-jsinspect gulp-load-plugins gulp-mocha gulp-param gulp-premailer gulp-print gulp-sass gulp-sourcemaps gulp-spawn-mocha gulp-wrap js-beautify jsinspect mocha mongobackup nock node-inspector node-xlsx nodemon phantom phantomjs recursive-readdir selenium-webdriver sinon sinon-chai uglify-js
[13:45:10] gulp-load-plugins: renaming gulp-autoprefixer to autoprefixer
[13:45:10] gulp-load-plugins: lazyload: adding property autoprefixer
[13:45:10] gulp-load-plugins: renaming gulp-concat to concat
[13:45:10] gulp-load-plugins: lazyload: adding property concat
[13:45:10] gulp-load-plugins: renaming gulp-debug to debug
[13:45:10] gulp-load-plugins: lazyload: adding property debug
[13:45:10] gulp-load-plugins: renaming gulp-env to env
[13:45:10] gulp-load-plugins: lazyload: adding property env
[13:45:10] gulp-load-plugins: renaming gulp-eslint to eslint
[13:45:10] gulp-load-plugins: lazyload: adding property eslint
[13:45:10] gulp-load-plugins: renaming gulp-header to header
[13:45:10] gulp-load-plugins: lazyload: adding property header
[13:45:10] gulp-load-plugins: renaming gulp-jsinspect to jsinspect
[13:45:10] gulp-load-plugins: lazyload: adding property jsinspect
[13:45:10] gulp-load-plugins: renaming gulp-mocha to mocha
[13:45:10] gulp-load-plugins: lazyload: adding property mocha
[13:45:10] gulp-load-plugins: renaming gulp-param to param
[13:45:10] gulp-load-plugins: lazyload: adding property param
[13:45:10] gulp-load-plugins: renaming gulp-premailer to premailer
[13:45:10] gulp-load-plugins: lazyload: adding property premailer
[13:45:10] gulp-load-plugins: renaming gulp-print to print
[13:45:10] gulp-load-plugins: lazyload: adding property print
[13:45:10] gulp-load-plugins: renaming gulp-sass to sass
[13:45:10] gulp-load-plugins: lazyload: adding property sass
[13:45:10] gulp-load-plugins: renaming gulp-sourcemaps to sourcemaps
[13:45:10] gulp-load-plugins: lazyload: adding property sourcemaps
[13:45:10] gulp-load-plugins: renaming gulp-spawn-mocha to spawnMocha
[13:45:10] gulp-load-plugins: lazyload: adding property spawnMocha
[13:45:10] gulp-load-plugins: renaming gulp-wrap to wrap
[13:45:10] gulp-load-plugins: lazyload: adding property wrap
[13:45:11] Using gulpfile ~/Projects/genericGit/gulpfile.js
[13:45:11] Starting 'test-unit'...
[13:45:11] gulp-load-plugins: lazyload: requiring gulp-env...
[13:45:11] gulp-load-plugins: lazyload: requiring gulp-print...
[13:45:11] gulp-load-plugins: lazyload: requiring gulp-mocha...
[gulp] test/generic/unit/controllers/test-accountCenterController.js
[gulp] test/generic/unit/controllers/test-applicationProcessingController.js
[gulp] test/generic/unit/controllers/test-controller.js
[gulp] test/generic/unit/controllers/test-createAccountController.js
[gulp] test/generic/unit/controllers/test-differenceController.js
[gulp] test/generic/unit/controllers/test-faqsAnswersController.js
[gulp] test/generic/unit/controllers/test-learnController.js
[gulp] test/generic/unit/controllers/test-productController.js
[gulp] test/generic/unit/controllers/test-quoteController.js
[gulp] test/generic/unit/controllers/test-quoteResultsController.js
[gulp] test/generic/unit/controllers/test-quoteReturnController.js
[gulp] test/generic/unit/controllers/test-genericAppController.js
[gulp] test/generic/unit/models/test-genericApplicant.js
[gulp] test/generic/unit/models/test-genericCustomer.js
[gulp] test/generic/unit/models/test-genericPerson.js
-_-_-_-_-_-_-_-_-_-_-_-_-__,------,
 33  -_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-__,------,
 0   -_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-__|  /\_/\
 0   -_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_~|_( ^ .^)
     -_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_ ""  ""

  33 passing (579ms)
nikmash commented 8 years ago

@knpwrs figured it out. Turns out gulp-load-plugins isn't playing nicely with gulp-spawn-mocha.

knpwrs commented 8 years ago

Interesting. If you can figure out a fix I'd accept a PR to get it working, otherwise I'm going to close this for now.

c0bra commented 7 years ago

Just a note: seems to be at least running istanbul with gulp-load-plugins for me. It's not covering the right files but that might be a configuration issue.