search

knqyf263 / go-plugin

Go Plugin System over WebAssembly
MIT License
586 stars 30 forks source link

Skip generating if no plugin and host services are not defined #26

Closed dmvolod closed 1 year ago

dmvolod commented 1 year ago

Description of changes:

Skip generating if no plugin and host services are not defined. Otherwise, in case of update/remove host section, files will not be regenerated

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codefromthecrypt commented 1 year ago

right now, we don't have any tests except the examples directory. could you put one in there to ensure the intended effect?

dmvolod commented 1 year ago

Sorry, @codefromthecrypt I thought, that this fix will be enough for creating redistrubitable host functions and test just need to be added. However, the task turned out to be a little more difficult. Closing this PR, as it superseded by the #27 Please have a look at this when possible and if this approach is suitable, I will fix doc for it. Thanks in advance.