search

knqyf263 / go-plugin

Go Plugin System over WebAssembly
MIT License
573 stars 27 forks source link

Use `unsafe.Slice` instead of `reflect.SliceHeader` to build byte slice #65

Closed inliquid closed 2 weeks ago

inliquid commented 3 weeks ago

Issue #, if available:

64

Description of changes: Use unsafe.Slice instead of reflect.SliceHeader to build byte slice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

inliquid commented 3 weeks ago

@evacchi sorry for tagging, but could you please take a look, as the linked issue prevents us from using recent versions of tinygo (v0.32.0 and v0.33.0).

inliquid commented 3 weeks ago

Thank you for a quick review! Looking forward for a merge 😊

knqyf263 commented 3 weeks ago

I triggered tests.

inliquid commented 3 weeks ago

I triggered tests.

@knqyf263 sorry, I missed this somehow. I tested on a different environment (including compilation with tinygo v0.31.*) where import was removed by IDE, but forgot this part when was preparing PR. Should be fixed now

inliquid commented 2 weeks ago

@knqyf263 can you please tag a new version?

knqyf263 commented 2 weeks ago

Yes, but the main branch is failing... https://github.com/knqyf263/go-plugin/actions/runs/10570578373/job/29285270109

inliquid commented 2 weeks ago

Thanks! I see, I will analyze it and open an issue.