search

knqyf263 / go-plugin

Go Plugin System over WebAssembly
MIT License
586 stars 30 forks source link

Add option to disable protobuf generation #69

Closed saschagrunert closed 1 day ago

saschagrunert commented 2 days ago

Refers to https://github.com/knqyf263/go-plugin/issues/67

Testing it in https://github.com/containerd/nri/pull/121

saschagrunert commented 2 days ago

https://github.com/containerd/nri/pull/121 compiles now locally.

saschagrunert commented 2 days ago

Can confirm it works for my local tests.

saschagrunert commented 2 days ago

@knqyf263 PTAL

saschagrunert commented 1 day ago

Thanks for your contribution! Could you also update README? It should mention how to use go-plugin with protoc-gen-go with an example command.

Sure, I updated the README as suggested.

knqyf263 commented 1 day ago

Thanks