search

knqyf263 / pet

Simple command-line snippet manager
MIT License
4.58k stars 230 forks source link

Add pet in Terra repo guide #318

Closed Owen-sz closed 1 month ago

Owen-sz commented 1 month ago

Description of changes:

I recently packaged pet into the Terra repository, a 3rd party repository for Fedora/Fedora based distributions, so I have added this to your README.

I also added Fedora in the RPM download guide, along with RedHat/CentOS, as I feel it should be there.

Link to package PR: https://github.com/terrapkg/packages/pull/2127

RamiAwar commented 1 month ago

Hey @Owen-sz, thank you so much for doing this! This will make a lot of users happy 🙂 🥳 🎊

Just to triple check, even though I did some research, the package will for sure be built from the Github source right? Doesn't expose it to people uploading their own binaries in the future or specifying custom source code.

Well I guess if the source on that terra repo changed to a custom repo in the future then it might be dangerous, but that's on the terra maintainers to ensure the right repo is used right?

Just trying to make sure we don't encourage something unsafe in our readme.

Owen-sz commented 1 month ago

Well I guess if the source on that terra repo changed to a custom repo in the future then it might be dangerous, but that's on the terra maintainers to ensure the right repo is used right

You're welcome! And yes, your assumptions are correct. I am a part of the project that maintains Terra, and we have a maintainer personally review each pull request, so changing the repo, and by extent a malicious change, should never get merged.

RamiAwar commented 1 month ago

Amazing, thank you! And thanks for the PR again 🙂 @Owen-sz