Remove IsString instance

knrafto / language-bash

Parse and pretty-print Bash shell scripts

BSD 3-Clause "New" or "Revised" License

35 stars 9 forks source link

Remove IsString instance #19

Closed mgsloan closed 7 years ago

mgsloan commented 7 years ago

This is necessary, as otherwise you get overlapping instances with GHC 8

I also renamed fromString :: String -> Word to stringToWord, because I think it's confusing to have both a local fromString along with Data.String.fromString. In particular, on first sight of the instance, it looked a lot like an infinite loop!

instance Data.String.IsString Word where        
    fromString = fromString

knrafto commented 7 years ago

Seems reasonable. Thanks for the PR!

We can remove the OverloadedStrings (and maybe FlexibleInstances) from these files now, right?

mgsloan commented 7 years ago

Good point! I've removed OverloadedStrings where possible.

knrafto commented 7 years ago

Now on Hackage as 0.7.0!