Fixes #28 - Githubissues

knrafto / language-bash

Parse and pretty-print Bash shell scripts

BSD 3-Clause "New" or "Revised" License

35 stars 9 forks source link

Closed mmhat closed 4 years ago

mmhat commented 4 years ago

Small changelog:

Replaced char, int, text with pretty
Doc with Doc ann
Removed Pretty class; prettyprinter has already one. One must take care of the use of prettyList since the default implementations are differs from the one used in out Pretty class.
Incorporated BashDoc from #24. I also added two tests for it and some Haddock documentation.

Uses prettyprinter>=1.4.0. I'm really looking forward to see this merged.

mmhat commented 4 years ago

Ok, Travis loves us! And if your review is positive as well I'd say: Let's merge!

knrafto commented 4 years ago

Okay, I played around with it a little. Other than the missing newline issue, it looks good to go :) thanks again!

mmhat commented 4 years ago

Ok, I addressed your concerns. It passes all tests in #30. (Note: I updated this PR, too.) The reason for the CI failure is #17.