use local cookiejar to support multiple usernames; fixes #10

knuckleheadsmiff / homebridge-garagedoor-ryobi

Homebridge plugin for Ryobi GDO (Garage Door Opener)

4 stars 4 forks source link

use local cookiejar to support multiple usernames; fixes #10 #11

Closed andyedinborough closed 4 years ago

andyedinborough commented 4 years ago

This PR creates a cookie jar instance local to the plugin instance to support multiple accounts.

knuckleheadsmiff commented 4 years ago

Thanks. I’ll incorporate on Friday when I have more time. I appreciate your work.

andyedinborough commented 4 years ago

Sorry it took me so long 😉

knuckleheadsmiff commented 4 years ago

This fix works but....but it looks like the root bug to the user in issue #10 may have been because he passed in a "garagedoor_id" rather than a "garagedoor_name" and that it looked like the code expects this.deviceid to be a function when it is a constant that is passed in. I can thing of a few ways to fix but I'll let you do it. ;-)

I made some other minor unrelated edits so be sure to update first.

thanks.