search

knuckleswtf / scribe

Generate API documentation for humans from your Laravel codebase.✍
https://scribe.knuckles.wtf/laravel/
MIT License
1.59k stars 281 forks source link

camelCase route parameter so multi-word model binding works #670

Closed Rasmus-Bertell closed 1 year ago

Rasmus-Bertell commented 1 year ago

Changes multi-word url parameters from snake_case to camelCase so it matches the model name in array. Propably should handle the case changing in some other way, I'll look into it later.

I don't know how to write a test for this, so any help is welcome.

closes #669

shalvah commented 1 year ago

Sorry, haven't had a chance to try this and decide if it's what we actually want. Will probably not be able to check it out until end of the month, when I'm back from vacation.

Rasmus-Bertell commented 1 year ago

Sorry, haven't had a chance to try this and decide if it's what we actually want. Will probably not be able to check it out until end of the month, when I'm back from vacation.

I still need to figure out how to write the test case for this, it would demonstrate the issue better in my opinion.

shalvah commented 1 year ago

Maybe take a look at the existing tests. I can't recall off the top of my head, but there's a class where we test some different URL parameter matching scenarios.