knuckleswtf / scribe

Generate API documentation for humans from your Laravel codebase.✍
https://scribe.knuckles.wtf/laravel/
MIT License
1.7k stars 303 forks source link

Refactor CustomTranslationsLoader for Compatibility with Statamic #679

Closed okaufmann closed 1 year ago

okaufmann commented 1 year ago

This PR addresses a compatibility issue with Statamic. The CustomTranslationsLoader class was previously using FileLoader, which led to conflicts as Statamic also mutates the loader.

To resolve this, we've refactored CustomTranslationsLoader to use LoaderContract instead of FileLoader. This change enhances flexibility and ensures compatibility with Statamic and potentially other packages that mutate the loader.

Key Changes:

This change is crucial for ensuring our package's seamless integration with Statamic. Please review and provide feedback.