search

knuckleswtf / scribe

Generate API documentation for humans from your Laravel codebase.✍
https://scribe.knuckles.wtf/laravel/
MIT License
1.59k stars 280 forks source link

GET method query param set from request #742

Closed sudippalash closed 8 months ago

sudippalash commented 8 months ago
shalvah commented 8 months ago

Please tell me what this is supposed to do, and include a before/after if you want me to merge it.

sudip-fe commented 8 months ago

Please tell me what this is supposed to do, and include a before/after if you want me to merge it.

Your package is awesome if developer is using DocBlocks in every function. But when developer not use DocBlocks before his function then your package generate from validation roles. It's also awesome but generate from validation roles only applicable for POST & PUT route. GET route query param not working for this scenario, That's why i am adding this code.

Check the below image: image

shalvah commented 8 months ago

Ah, I see. But that isn't the right solution. Check the docs for how to use validation rules for query parameters. https://scribe.knuckles.wtf/laravel/documenting/query-body-parameters#using-validation-rules-for-query-parameters