search

knuckleswtf / scribe

Generate API documentation for humans from your Laravel codebase.✍
https://scribe.knuckles.wtf/laravel/
MIT License
1.58k stars 280 forks source link

Enable form validations to support required attributes #789

Closed Dinushasilva closed 3 months ago

Dinushasilva commented 5 months ago

This pull request introduces support for validating required form attributes.

Before:

theme-elements-before theme-default-before

After:

theme-elements-after theme-default-after

codespearhead commented 4 months ago

Can you add a failing test that passes after patching the source code?

shalvah commented 4 months ago

Thanks for the suggestion @codespearhead . I'm fine with this as is, since it's a frontend feature. I'm just dubious about accepting the feature, because it's possible people may want to see how the API behaves in cases of missing parameters.

MrCrayon commented 4 months ago

I'm just dubious about accepting the feature, because it's possible people may want to see how the API behaves in cases of missing parameters.

I totally agree, IMHO this form should not validate any input.