knuckleswtf / scribe

Generate API documentation for humans from your Laravel codebase.✍
https://scribe.knuckles.wtf/laravel/
MIT License
1.58k stars 280 forks source link

Missing translations #791

Closed Rasmus-Bertell closed 5 months ago

Rasmus-Bertell commented 5 months ago

Scribe version

4.29.0

Your question

I'm not 100% sure but I think some rules used to be translated and now show only the translation keys, for example I have a lot of validation rules defined with uuid and the description for them now shows only validation.uuid. instead of something like must be a valid uuid or whatever it was earlier. Is this intentional or is there something broken either on my end or in the package?

Docs

Rasmus-Bertell commented 5 months ago

Config diff

base_url => "http://localhost:8000"
type => "laravel"
try_it_out.base_url => "http://localhost:8000"
Rasmus-Bertell commented 5 months ago

I did some bisecting and couldn't find a working commit so I'll have to assume this is how it's supposed to work unless I have something configured wrong in my project, but that's not a scribe problem.

Rasmus-Bertell commented 5 months ago

For anyone having the same problem, it was my locale setup. I had app locale set as en_US but the translations were only available for en.

shalvah commented 5 months ago

Is this a gap with the package? Does Laravel support en_US, separately from en?

Rasmus-Bertell commented 5 months ago

Laravel by default only has translations for en but publishing the English translations and moving them to en_US folder works with laravel and scribe.