Refactor for easier customization

[Peterragheb]

Scribe version

4.29.0

Your question

I'm wondering it's possible to do some code refactoring to allow easier customization

for example in the GenerateDocumentation command you instantiate the Writer class using the new keyword. Why not use the service container to instantiate it this way it would be easier to custom bind it. (of course there's a lot of other options like adding it to the config file but I think the container is the fastest and easiest solution)

Same for instantiating the CustomTranslationsLoader in the ScribeServiceProvider.

Btw these are the classes I had to customize in order to get the localization to work the way I want it to. This includes:

• Setting the scribe.php lang file under the correct locale directory (Had to customize CustomTranslationsLoader)
• Generating the docs blade file under a locale directory inside the views folder for example resources/views/scribe/en/index.blade.php (Had to customize the Writer)

Docs

• [X] I've checked the docs, the troubleshooting guide, and existing issues, but I didn't find a solution

[shalvah]

Sure, PR welcome. In general, I didn't go with the approach of using the Laravel container because I wanted it to be easily testable in isolation.

[Peterragheb]

@shalvah here's the PR https://github.com/knuckleswtf/scribe/pull/822

Btw I think the localization can be improved a bit.

• Allow lang file to be under locale folder
• Translate Docs title & description
• Translate hardcoded strings in blade files

let me know if you're okay with that and I'll work on a PR

[shalvah]

If you can make it work while still making sense for the end user and not having too much maintenance overhead, sure 👍