knurling-rs / defmt

Efficient, deferred formatting for logging on embedded systems
https://defmt.ferrous-systems.com/
Apache License 2.0
750 stars 69 forks source link

Mention the need for Encoder in certain cases in documentation #770

Open Qix- opened 11 months ago

Qix- commented 11 months ago

Trying to implement defmt for a custom board/serial line was a little bit of a headache just reading through the documentation. Maybe some improvements to the docs can be made.

I'm sure to people who use defmt often this is all trivial but as a complete newcomer to defmt (having previously stored all logging strings directly in the firmware itself), it wasn't obvious what was happening or how this was supposed to work, especially trying to implement my own wire debugging.

Perhaps some of the docs could mention these sorts of cases on the relevant pages? I actually didn't get to the "introduction" page from google, but rather the "Setup" page. A "Guide for Implementors" page (which really is the global_logger page, more or less) could have a lot more information about this, I think.

Urhengulas commented 11 months ago

Hi @Qix- 👋🏾

Thank you for your message! Making our documentation more beginner-friendly is definitely something we have to work on.

Would you be interested in proposing changes to the docs to make it more clear? Since you just went through the process you probably know quite well what would have helped you. If yes, please just send a PR. If not we can totally also work on it.

🥂

Qix- commented 11 months ago

Sure thing! I'll try to get some time this week to do it :) Thanks for the response.