search

knurling-rs / defmt

Efficient, deferred formatting for logging on embedded systems
https://defmt.ferrous-systems.com/
Apache License 2.0
750 stars 69 forks source link

Licenses are missing copyright information #814

Open arctic-alpaca opened 4 months ago

arctic-alpaca commented 4 months ago

Hi,

both the Apache 2 and the MIT license are missing the copyright information. For the Apache 2 license, the copyright placeholder is not filled in: https://github.com/knurling-rs/defmt/blob/main/LICENSE-APACHE#L189 For the MIT license, the copyright part at the top (Copyright <YEAR> <COPYRIGHT HOLDER>, see here) is missing.

jonathanpallant commented 4 months ago

The copyright line in that part of the Apache-2.0 licence is a template and is not supposed to be modified in the licence file itself. If you changed it, then you have a) modified the licence, and b) are telling anyone who reads your modified copy of the licence that they must put your copyright in their files when they wish to release it under your modified Apache-2.0 licence.

The copyright line is missing in the MIT file and we should fix that. I note it is also missing from the copy at GitHub.com/rust-lang so maybe we copied their file.

arctic-alpaca commented 4 months ago

You are correct, the Apache-2.0 license file should not be modified, my bad. Without any form of copyright notice, I'm unsure how the copyright is assigned when using this project under the Apache-2.0 license.

The Rust repository has a COPYRIGHT file.