search

knurling-rs / defmt

Efficient, deferred formatting for logging on embedded systems
https://defmt.ferrous-systems.com/
Apache License 2.0
849 stars 77 forks source link

defmt-macros depends on proc-macro-error which is considered unmaintained #863

Closed ia0 closed 1 month ago

ia0 commented 1 month ago

I'm using defmt and thus defmt-macros. I've recently got a security warning because I depend (through defmt) on proc-macro-error. See https://rustsec.org/advisories/RUSTSEC-2024-0370.html for more details. Would it be something you would consider to either migrate to proc-macro-error2 or avoid depending on proc-macro-error through another mean?

Urhengulas commented 1 month ago

Thank you for notifying us @ia0.

Either using proc-macro-error2 or just using syn::Result seem like viable options to me.

Would you be interested in making either change?

ia0 commented 1 month ago

Thanks for the answer.

This is not a big issue on my side so far (unmaintained crates don't really have an urgency aspect as other security issues may have), so I won't be able to allocate time for it, sorry.

Urhengulas commented 1 month ago

No worries. Gonna work on it when we get around then. Thank you for the notify!