Closed Urhengulas closed 3 years ago
main.rs will be heavily refactored, but this PR shouldn't be too painful to rebase onto the refactored code I think. If that*#s okay with you, I'd like to wait with merging this PR until after the refactoring is done.
main.rs will be heavily refactored, but this PR shouldn't be too painful to rebase onto the refactored code I think. If that*#s okay with you, I'd like to wait with merging this PR until after the refactoring is done.
Sure!
@Lotterleben I've rebased it onto the latest main.
feel free to bors rplus
bors r+
This implements the idea from @japaric to utilize the
git_version
crate for obtaining the git hash, instead of the custom build-script we used so far.In case
git
is not present on the system the reported version will only consist of theCARGO_PKG_VERSION
._note: I am a bit unsure where exactly to put the
extract_git_hash
helper function. I mainly considered theutils
module. I decided to put it intomain.rs
for now to not potentially conflict with the upcoming refactoring from @Lotterleben and @japaric._