"device halted without error" shouldn't be printed when using Ctrl+C

knurling-rs / probe-run

Run embedded programs just like native ones

Apache License 2.0

645 stars 75 forks source link

"device halted without error" shouldn't be printed when using Ctrl+C #231

Closed jonas-schievink closed 3 years ago

jonas-schievink commented 3 years ago

https://github.com/knurling-rs/probe-run/blob/563d92608b78eba211a3f333bb8135b3a3546b03/src/backtrace/mod.rs#L75

Lotterleben commented 3 years ago

Question while I'm working on this: Should a backtrace be printed by default after a user Ctrl+C's? From training experience, I'm leaning towards no (people think they've done something wrong when they see a backtrace). What do you think?

jonas-schievink commented 3 years ago

We've decided in https://github.com/knurling-rs/probe-run/issues/202 that it should print one

Lotterleben commented 3 years ago

got it, thx