search

knurling-rs / probe-run

Run embedded programs just like native ones
Apache License 2.0
643 stars 75 forks source link

Print dedicated message on control + c #248

Closed Lotterleben closed 3 years ago

Lotterleben commented 3 years ago

Resolves https://github.com/knurling-rs/probe-run/issues/231 , but in a slightly awkward way– imo halted_due_to_signal should be merged into Outcome but that's a bigger rabbithole and I wanted to open this PR first to get some general feedback and then tackle that in either this or a follow-up PR.

This PR also adds a test for this new functionality. I've slightly refactored our test helpers to accommodate the need for a "run and terminate" option. To ensure that tests still run sequentially, I'be switched them to serial_test.

While I was at it, I also fixed 2 typos I came across.

Lotterleben commented 3 years ago

@ test failure: welp.. yeah. I could've thought of that. -.-

jonas-schievink commented 3 years ago

Nice work!

bors r+

bors[bot] commented 3 years ago

Build succeeded: