search

knurling-rs / probe-run

Run embedded programs just like native ones
Apache License 2.0
645 stars 75 forks source link

use new stream decoder API #264

Closed japaric closed 2 years ago

japaric commented 2 years ago

fixes knurling-rs/defmt#575

marking as a draft because I want to update the manual snapshot tests before merging this

jonas-schievink commented 2 years ago

I think it would be good to set up the unit tests to always be built from source, that makes it easier to modify them

bors r+

bors[bot] commented 2 years ago

Build succeeded:

japaric commented 2 years ago

I think it would be good to set up the unit tests to always be built from source, that makes it easier to modify them

generally +1 to the idea of having the source in-tree. always rebuilding the snapshot binaries does have the complication that stuff can vary between systems and break the tests e.g. file paths, binary sizes, etc. resilience against that would require sort of wildcards in the .snap files (flashing program ({digit*}.{digit*} KiB))) which I'm not sure insta supports?