knurling-rs / probe-run

Run embedded programs just like native ones
Apache License 2.0
644 stars 75 forks source link

Disable terminal colorization if `TERM=dumb` is set #320

Closed Urhengulas closed 2 years ago

Urhengulas commented 2 years ago

This PR fixes the problem @fhars described in #318:

The current version of the colored crate ignores the capabilities of the terminal (see https://github.com/mackwic/colored/issues/108), which makes the outupt of probe-run unparseable in e.g. emacs compilation mode.

It also supersedes #318 as a fix to the problem. The reason for not going with #318 is that it adds the terminfo crate as a dependency which seems unmaintained and with many outdated dependencies.

jonas-schievink commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded: