search

knurling-rs / probe-run

Run embedded programs just like native ones
Apache License 2.0
646 stars 75 forks source link

Update to `clap 4.0` #357

Closed Urhengulas closed 1 year ago

Urhengulas commented 1 year ago

This PR updates our cli parser clap from 2.34 to 4.0.

The end-user experience should stay similar, but has a fresh UI, many internal improvements, and better help messages when a user gets the arguments wrong.

On the left you can see the new UI, and on the right the old. image

Urhengulas commented 1 year ago

Also it is not in alphabetic order anymore, so one need a few moments of looking up and down...

I was thinking about that as well. The reasoning of the authors of clap is that they want to give the cli authors (us) control over the order. We can just solve this by alphabetically ordering the args.

Urhengulas commented 1 year ago

bors r=Dajamante

bors[bot] commented 1 year ago

Build succeeded:

Urhengulas commented 1 year ago

why do we need Cargo.lock?

Afaik it is convention to commit the lock file for applications, but not for libraries.

can we put <HELPER_CMD> between arrows, or is it against conventions?

That would be possible.