search

knurling-rs / probe-run

Run embedded programs just like native ones
Apache License 2.0
646 stars 75 forks source link

Enable ftdi feature in probe-rs #377

Closed IridiumXOR closed 1 year ago

IridiumXOR commented 1 year ago

Please, can you enable the ftdi feature for probe-rs dependency in order to be able to use also FTDI debuggers? Thanks

Urhengulas commented 1 year ago

Hi @IridiumXOR,

Do you know if we would wantftdi or ftdi-vendored (https://github.com/probe-rs/probe-rs/blob/master/probe-rs/Cargo.toml#L26-L27)? I didn't find any documentation about the difference.

IridiumXOR commented 1 year ago

I think it's a problem of licence 1 and 2. If I have understood correctly, we would want ftdi (ftdi-vendored compile a static library in order to circumvent possible license problems (in the second link the authors seems to say that there are no license problems)

Urhengulas commented 1 year ago

@IridiumXOR Can you try if it works as you expect? Install probe-run with:

$ cargo install --git https://github.com/knurling-rs/probe-run --branch ftdi --features ftdi

You need to have libtfdi1 installed, but I am sure you know more about that than I do.

IridiumXOR commented 1 year ago

I'm looking into the code of branch ftdi, where is the part that enable the ftdi feature of probe-rs?

Urhengulas commented 1 year ago

Please see the changes in https://github.com/knurling-rs/probe-run/pull/381. You can install it with the instructions above.

Urhengulas commented 1 year ago

@IridiumXOR did you have the opportunity to test it?

IridiumXOR commented 1 year ago

Sorry, yes it works! you can close it