search

knurling-rs / probe-run

Run embedded programs just like native ones
Apache License 2.0
645 stars 75 forks source link

Hide location printing for defmt frames behind another verbosity level #413

Closed whitequark closed 11 months ago

whitequark commented 1 year ago

Depends on https://github.com/knurling-rs/defmt/pull/762.

Addresses #412 and #407.

This PR changes the default (without flags) output to omit location for all defmt frames. Personally I think this is more convenient when you're running your firmware and not debugging it since the log is easier to read and you don't care about locations at this point anyway, but this comes down to personal preference. A less invasive option is to add a --terse option and to set the verbosity level to 1 + opts.verbose - opts.terse; then the default output will remain the same.

A very minimal solution that addresses #412 but not #407 is to skip printing of location only for println! frames if always_include_location is not set, and leave everything else the same.

I'm happy to implement any of the options above, or really any other option that's suggested.

Urhengulas commented 1 year ago

Thank you. I will look into the topic

Urhengulas commented 11 months ago

Superseded by https://github.com/knurling-rs/probe-run/pull/416