knurling-rs / probe-run

Run embedded programs just like native ones
Apache License 2.0
645 stars 75 forks source link

Prepare `v0.3.11` (the final release) #431

Closed Urhengulas closed 8 months ago

Urhengulas commented 8 months ago

Using the deprecated attribute is a bit of a hack, but it was the easiest way to issue a warning on build time I could find.

Fixes #430


TODO

Urhengulas commented 8 months ago

@jonathanpallant The CI fails due to clippy, but I'd like to just ignore this.

jonathanpallant commented 8 months ago

Makes sense to me.

Can you post a sample of building / running the binary with this new deprecated function in it? Perhaps you can cargo install https://github.com/... ?

Urhengulas commented 8 months ago

@jonathanpallant said:

Can you post a sample of building / running the binary with this new deprecated function in it?

$ cargo install --path . --debug -q
warning: use of deprecated function `deprecated`: ⚠️  As of 11.10.2023 `probe-run` is in maintainance mode. We recommend everyone to switch to `probe-rs`. Read following article on the why and on how to migrate: https://ferrous-systems.com/blog/probe-run-deprecation/
  --> src/main.rs:53:5
   |
53 |     deprecated();
   |     ^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

$ probe-run
⚠️  As of 11.10.2023 `probe-run` is in maintainance mode. We recommend everyone to switch to `probe-rs`. Read following article on the why and on how to migrate: https://ferrous-systems.com/blog/probe-run-deprecation/

error: the following required arguments were not provided:
  --chip <CHIP>
  <ELF>

Usage: probe-run --chip <CHIP> <ELF>

For more information, try '--help'.
jonathanpallant commented 8 months ago

I was going to suggest adding a flag to turn the warning off, but actually I'd suggest they just fork the codebase and take the warning out if they care that much about some probe-run feature that probe-rs doesn't have.

https://github.com/ferrous-systems/rust-exercises/pull/66 is in, so this all seems fine to me.