search

knutwurst / Marlin-2-0-x-Anycubic-i3-MEGA-S

Marlin 2.0.x Version for Anycubic i3 MEGA M/S/P/X/CHIRON and 4MAX with Anycubic TFT or the "new" DGUS Clone TFT - Now also with BLTouch!
GNU General Public License v3.0
782 stars 183 forks source link

[FR] difference between this FW and stock marlin #452

Closed Ingegneus closed 1 year ago

Ingegneus commented 1 year ago

it's not really a feature request, but more an inquiry. what are the differences between this version of marlin and the stock version? I read the faq, but there isn't all that much info on this. maybe my request is to expand the faq to address this

edit: also I was wondering if using the mega x config of this FW would work with the stock marlin FW, since on that repo there is no config for the mega x

knutwurst commented 1 year ago

This is a hybrid firmware that does not require configuration files for individual printers. And the advantage over Stock Marlin should be the full support of the display and the additional functions in the special menu, which are not otherwise available.

However, some guys already pushed some features into the Marlin Upstream and therefore some features such as FlowControl are also available in Stock Marlin.

The advantage is perhaps also that all supported printers are preset without further configuration.

It's an it-just-works solution... at least it was when I built the firmware back then. And back then the Anycubic Display was not supported at all and even longer the DGUS Clone Display was not supported either. If that's the case in Marlin now, it's because someone copied the features from me. But that's okay too. It's open source.

Ingegneus commented 1 year ago

This is a hybrid firmware that does not require configuration files for individual printers

what does hybrid mean in this context? and it doesn't need config files, because there is one "master" file that contains all settings that are selected via the build flags right? so I could "extract" the config for the mega x and use it more or less as is (removing all the ENABLE statements) for marlin right?

ok I understand thank you very much!

knutwurst commented 1 year ago

Partly, yes. But it's not just about the pure "config". So I'm not just talking about the configuration.h or something. A lot also changes in the display routine and the type of display is also differentiated.

But if you want to have specific values, you can of course also use Stock Marlin + my config. I just don't know how well that works.

schmttc commented 1 year ago

@Ingegneus I had a similar question, here is a diff of the two https://github.com/schmttc/Marlin/compare/2.1.2...schmttc:Marlin:2.1.2-anycubic

@knutwurst are you interested in merging your firmware back into mainline Marlin? I think they would benefit from your work, and from the outside it seems simpler to have a single source of truth.

knutwurst commented 1 year ago

@schmttc I'm actually working on making my code as modular as possible and implementing a lot via ExtUI lately. So yes, some things should also flow directly into the current marlin sources in the near future. I just need to fix some bugs :)

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.