search

knutwurst / Marlin-2-0-x-Anycubic-i3-MEGA-S

Marlin 2.0.x Version for Anycubic i3 MEGA M/S/P/X/CHIRON and 4MAX with Anycubic TFT or the "new" DGUS Clone TFT - Now also with BLTouch!
GNU General Public License v3.0
788 stars 187 forks source link

[BUG] "Hotend temperature abnormal" warning never actually triggered #475

Closed stklcode closed 1 year ago

stklcode commented 1 year ago

Bug Description

We have a routine to check for heater errors using a timeout counter that is incremented if the temperature is out of range:

https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/blob/0981430d4be596ba4cc767ab4126921868ddb988/Marlin/src/lcd/extui/knutwurst/anycubic_touchscreen.cpp#L982-L984

The counter condition will never be true, because HeaterCheckCount is declared uint16_t which is bound to [0, 65535].

https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/blob/0981430d4be596ba4cc767ab4126921868ddb988/Marlin/src/lcd/extui/knutwurst/anycubic_touchscreen.h#L230

Steps to Reproduce

  1. Let the printer under- or overheat
  2. Wait some time

(no, you should probably not try this at home :wink:)

Expected behavior: An error "Hotend temperature abnormal..." should pop up.

Actual behavior: Nothing.

(no, I did not test this for real, but the behavior should be pretty straight forward from the code)

Additional Information

--

Question

600.000 is pretty high. This was actually increased from 60.000 in 85bac6b3960966b49f23a694cf75562842f26e80

Should we lower the limit again or increase the counter size to uint32_t or similar?

knutwurst commented 1 year ago

To be honest - I don't know why I increased the heater check count. Maybe it's a good Idea to lower it an test everything.

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.