search

knyar / theoldreader-chrome

Chrome extension for The Old Reader
http://theoldreader.com/
MIT License
15 stars 9 forks source link

Feature suggestion: i18n #16

Closed kav2k closed 7 years ago

kav2k commented 11 years ago

It's obvious that this extension could benefit from i18n, since we now have an options page. Also helps with translating extension description.

Guidelines for implementation: http://developer.chrome.com/extensions/i18n.html

knyar commented 11 years ago

To be honest, I am quite skeptical towards i18n. The extension only has a handful of options, and everyone having even a basic command of English can understand them. If you would be willing to make a patch, I will gladly approve it, but personally I don't think this is something worth spending time on.

kav2k commented 11 years ago

I'm not marking it as wontfix, but I'm not going to work on it in the near future, so I'm de-assigning myself. Anyone able is welcome to contribute.

In principle, we all know that English is not THAT universal a language. Russia is, unfortunately, a good example. The Old Reader itself has i18n, so this ideally should too.

MikkCZ commented 7 years ago

I don't think this will need any big changes. Taking this.

kav2k commented 7 years ago

Note: besides implementation costs there is ongoing support cost of keeping translations (if any) up to date and make sure submitted translations are not malicious (yes, that can happen).

MikkCZ commented 7 years ago

I see. Thankfully chrome.i18n supports fallbacks, so in case the translation is not up to date, in the worst case the user will see English again.

kav2k commented 7 years ago

I really don't think there's enough need for this, considering that TOR itself does not have locales other than English.

MikkCZ commented 7 years ago

Tor maybe not, but Chrome/Chromium and Firefox do have plenty.

MikkCZ commented 7 years ago

And as this add-on provides 3rd party service (The Old Reader) integration, I would expect it to support similar languages portfolio, what the service does. By the way, how is the web ui localization quality and correctness ensured?

MikkCZ commented 7 years ago

Hopefully I haven't missed anything here. But frankly Chrome does not support . in the string IDs, so I will need to change all the string IDs. :/

MikkCZ commented 7 years ago

Oh, by TOR you meant The Old Reader, not Tor browser. Well, The Old Reader does support other locales. https://github.com/theoldreader/i18n

kav2k commented 7 years ago

Oops, indeed it does.