search

knyghtmare / War_of_Legends

An add-on for the Battle for Wesnoth, a turn-based strategy game. This add-on is a multiplayer era featuring my favorite factions. It is required as a dependency to play several campaigns.
GNU General Public License v2.0
7 stars 6 forks source link

Retire non-functional inventory systems and adjust campaigns with WISh #174

Closed knyghtmare closed 2 weeks ago

knyghtmare commented 1 month ago

So far WISh Seems to be the best thing to use compared to the four existing things. It's best take in the sister add-on and retire the rest. I dont think anybody else uses the other 3 in WoL (I checked and WoL using authors are not even aware.)

To remove:

Not Sure:

knyghtmare commented 1 month ago

@babaissarkar Thoughts on when would be the appropriate time for this Issue to be addressed? I just listed it down so that it's not forgotten for now.

babaissarkar commented 1 month ago

WISh is fairly stable, except for

  1. The equip/unequip is unrestricted.

I'd suggest you to give WISh a test run yourself and if you think it works better than the existing system, you can integrate it and proceed to remove any defunct code.

(I'd like to to publish WISh as a separate addon if possible, as we discussed earlier.)

On Fri 9 Aug, 2024, 8:39 PM Tahsin Jahin Khalid, @.***> wrote:

@babaissarkar https://github.com/babaissarkar Thoughts on when would be the appropriate time for this Issue to be addressed? I just listed it down so that it's not forgotten for now.

— Reply to this email directly, view it on GitHub https://github.com/knyghtmare/War_of_Legends/issues/174#issuecomment-2278173211, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACAT3AB5FGMPEA4FTKRF433ZQTLT3AVCNFSM6AAAAABMIOVR7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYGE3TGMRRGE . You are receiving this because you were mentioned.Message ID: @.***>

knyghtmare commented 1 month ago

(I'd like to to publish WISh as a separate addon if possible, as we discussed earlier.)

I guess we can go with that route.

I'd suggest you to give WISh a test run yourself and if you think it works better than the existing system, you can integrate it and proceed to remove any defunct code.

Yeah, I am planning too. Started the process in the SotBE rework. Need to make some basic usable pieces for the orcs.

knyghtmare commented 1 month ago

So, none of the existing works are affected thus, to adjust are: