search

knz / go-libedit

Go wrapper around the BSD libedit replacement to GNU readline
Apache License 2.0
6 stars 6 forks source link

add illumos support #23

Closed davepacheco closed 2 years ago

davepacheco commented 2 years ago

This change adds support for illumos systems. I tested this by building and running the example program and seeing that I could use things like up-arrow (which I couldn't prior to this change).

knz commented 2 years ago

nice. Thank you!

davepacheco commented 2 years ago

Thanks! I ran into this using CockroachDB. Should I submit a PR to cockroachdb/vendored to sync up with this?

knz commented 2 years ago

that's not the right way to do it. the right way to do it is to submit a pr against the crdb repository.

if you're not sure how to do this, please file a crdb issue.

davepacheco commented 2 years ago

Thanks. Filed cockroachdb/cockroach#70394.