search

knz / go-libedit

Go wrapper around the BSD libedit replacement to GNU readline
Apache License 2.0
6 stars 6 forks source link

Fix compiler warnings on linux #5

Closed benesch closed 6 years ago

benesch commented 6 years ago

Fix #2.

I realize this came from upstream, but, ¯_(ツ)_/¯ , it seems broken.

benesch commented 6 years ago

No upstream patch available, AFAICT. At least, the code here still looks the same: https://anonscm.debian.org/cgit/collab-maint/libedit.git/tree/src/common.c (I don't have a Linux box handy to test on.)

Also perhaps you should file a patch upstream too.

Upstream appears to be NetBSD—any suggestions for getting a NetBSD VM? I just spent an hour trying to get something running on my laptop via VirtualBox and on EC2 but neither worked.

knz commented 6 years ago

Upstream appears to be NetBSD

Yes and there are cross-updates across BSDs too.

I'd say submit a bug fix + proposed patch on both the NetBSD and FreeBSD issue trackers.

Don't bother downloading the sources. Just check manually your diff is relevant for http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/ and https://github.com/freebsd/freebsd/tree/master/lib/libedit and mention the file/linenos in the issue reports:

https://bugs.freebsd.org/bugzilla/enter_bug.cgi

http://www.netbsd.org/cgi-bin/sendpr.cgi?gndb=netbsd

benesch commented 6 years ago

Alright, filed: https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=53058