Closed ratsgo closed 4 years ago
수행 내용
@ratsgo 저희가 lint 신경을 안쓴게 많아서 lint fail 한 것 같습니다. lint error 수정부터 먼저 하고, 혹은 우리가 ignore 할 유형이 있을지 먼저 협의해 보면 어떨까요?
$ Korpora % flake8 Korpora
Korpora/fetch.py:31:80: E501 line too long (89 > 79 characters)
Korpora/fetch.py:36:80: E501 line too long (88 > 79 characters)
Korpora/fetch.py:41:2: W292 no newline at end of file
Korpora/korpora.py:4:1: F401 '.utils.default_korpora_path' imported but unused
Korpora/korpora.py:20:80: E501 line too long (103 > 79 characters)
Korpora/__init__.py:4:1: F401 '.korpora_nsmc.NSMC' imported but unused
Korpora/__init__.py:5:1: F401 '.loader.Korpora' imported but unused
Korpora/korpora_nsmc.py:15:80: E501 line too long (94 > 79 characters)
Korpora/korpora_nsmc.py:27:12: E124 closing bracket does not match visual indentation
Korpora/korpora_nsmc.py:30:80: E501 line too long (85 > 79 characters)
Korpora/korpora_nsmc.py:31:80: E501 line too long (82 > 79 characters)
Korpora/korpora_nsmc.py:52:80: E501 line too long (89 > 79 characters)
Korpora/utils.py:29:80: E501 line too long (90 > 79 characters)
Korpora/utils.py:40:80: E501 line too long (99 > 79 characters)
Korpora/utils.py:41:80: E501 line too long (96 > 79 characters)
Korpora/utils.py:49:80: E501 line too long (83 > 79 characters)
Korpora/utils.py:50:80: E501 line too long (100 > 79 characters)
Korpora/utils.py:59:1: E302 expected 2 blank lines, found 1
Korpora/utils.py:61:80: E501 line too long (103 > 79 characters)
Korpora/utils.py:62:80: E501 line too long (80 > 79 characters)
Korpora/loader.py:22:80: E501 line too long (98 > 79 characters)
@ratsgo 저희가 lint 신경을 안쓴게 많아서 죽는거 같습니다. 이 부분 수정부터 먼저 하고, 혹은 우리가 ignore 할 유형이 있을지 먼저 협의해 보면 어떨까요?
$ Korpora % flake8 Korpora Korpora/fetch.py:31:80: E501 line too long (89 > 79 characters) Korpora/fetch.py:36:80: E501 line too long (88 > 79 characters) Korpora/fetch.py:41:2: W292 no newline at end of file Korpora/korpora.py:4:1: F401 '.utils.default_korpora_path' imported but unused Korpora/korpora.py:20:80: E501 line too long (103 > 79 characters) Korpora/__init__.py:4:1: F401 '.korpora_nsmc.NSMC' imported but unused Korpora/__init__.py:5:1: F401 '.loader.Korpora' imported but unused Korpora/korpora_nsmc.py:15:80: E501 line too long (94 > 79 characters) Korpora/korpora_nsmc.py:27:12: E124 closing bracket does not match visual indentation Korpora/korpora_nsmc.py:30:80: E501 line too long (85 > 79 characters) Korpora/korpora_nsmc.py:31:80: E501 line too long (82 > 79 characters) Korpora/korpora_nsmc.py:52:80: E501 line too long (89 > 79 characters) Korpora/utils.py:29:80: E501 line too long (90 > 79 characters) Korpora/utils.py:40:80: E501 line too long (99 > 79 characters) Korpora/utils.py:41:80: E501 line too long (96 > 79 characters) Korpora/utils.py:49:80: E501 line too long (83 > 79 characters) Korpora/utils.py:50:80: E501 line too long (100 > 79 characters) Korpora/utils.py:59:1: E302 expected 2 blank lines, found 1 Korpora/utils.py:61:80: E501 line too long (103 > 79 characters) Korpora/utils.py:62:80: E501 line too long (80 > 79 characters) Korpora/loader.py:22:80: E501 line too long (98 > 79 characters)
네 좋습니다. 위의 수정은 진행해주시면 될 것 같고요. 이와 별개로 CI 환경 만드는거(requirement.txt에 tqdm 등 의존성 패키지 명시, CI 도커 실행할 때 파이썬 버전을 3.7로 지정 등)는 제가 계속 진행하고 있을게요.
진행하고
넵 dev branch 확인했습니다. 이 부분은 PR 최소하고 dev PR 부탁드립니다.
네 이 PR은 회수하겠습니다
개요
Continuous Integration 테스트를 위한 테스트 Pull Request