search

ko-vasilev / Hearthstone-Collection-Tracker

A plugin for Hearthstone Deck Tracker that allows to keep track on pack sets
75 stars 47 forks source link

Collection Tracker 0.2.4 is not compatible with HDT 0.13.11 #68

Closed schnapster closed 8 years ago

schnapster commented 8 years ago

Collection Tracker 0.2.4 is not compatible with HDT 0.13.11

Getting following error upon trying to import:

ss 2016-02-18 at 02 53 47

feriancek commented 8 years ago

+1, same error. Windows 10 64bit if it matters.

koppite commented 8 years ago

Some information for what I got by playing around a bit.

I added plugin built from the latest source and it got past this error shown by op. However it then got stuck reading the image (within the Hearthstone Deck Tracker), and therefore it never got past the first card of the collection (Fen Creeper).

The only way I was able to fix this was to alter the HearthStoneDeckTracker function CaptureHearthstone in Hearthstone Deck Tracker\utility\helper.cs to by synchronous. As it seemed the await inside CaptureHearthstoneAsync was never completing even though internally the Task was successfully grabbing a bmp of the required section.

I imagine the changing of this function inside the Deck Tracker project would have a more wider implication that someone over there would need to answer if it would impact other functionality by changing.

ermosk commented 8 years ago

Same issue here

cachirro commented 8 years ago

here too

whyleee commented 8 years ago

:+1:

Stoutt commented 8 years ago

Same error as well ... just in English.

mssign commented 8 years ago

:-@

feriancek commented 8 years ago

image

Issue continues with newest release of HDT

koppite commented 8 years ago

As their don't seem to be any updates coming on here recently I have made the changes to make it compatible with 0.13.12 on my fork -> https://github.com/koppite/Hearthstone-Collection-Tracker/releases/tag/0.2.4.1

Let me know over there if there any issues.

Ansem93 commented 8 years ago

I think that you should link your fork into the main page of HDT, This project is nearly dead after 5 months of 0 update :( btw it works for me, so thank you a lot! P.S. what's update collection?

culinko commented 8 years ago

This project is not dead. I'm pretty sure that author is just busy with his exams and will update it as soon as he can.

ko-vasilev commented 8 years ago

Fixed with cc26147c6936cc84c708b710e12adf1dde310f23.