search

ko4life-net / ko

Open source development of the game Knight Online. This is a reversed engineered old version of the game aiming to replicate the nostalgic experience we all once had <3
MIT License
52 stars 21 forks source link

When exiting the game, character data is not being saved #132

Closed stevewgr closed 4 months ago

stevewgr commented 1 year ago

Description

When exiting the game, character data is not being saved.

This could be either server side code issue or most likely a stored procedure.

To Reproduce

  1. Create character
  2. Level up
  3. Exit the game
  4. Login back

You'll start over.

Tasks

stevewgr commented 1 year ago

@xGuTeK already have it fixed and this is currently pending for a PR.

srmeier commented 1 year ago

@stevewgr @xGuTeK Which PR is this?

stevewgr commented 1 year ago

@stevewgr @xGuTeK Which PR is this?

There was no PR unfortunately. @xGuTeK mentioned to me back then in regards to some of the tickets that he had fixed some of them, but these were local changes that he never pushed remotely. Feel free to take over if you see similar comments.

stevewgr commented 1 year ago

I unassigned him from the other tickets as well just to avoid confusion.

srmeier commented 1 year ago

@stevewgr Would assign this one to @selcukcukur. He has done some work here #200 and I assume he will open new PRs to address this issue.

selcukcukur commented 1 year ago

You can find the fix for the issue here. #201

stevewgr commented 4 months ago

This ticket was solved part of this ticket: https://github.com/ko4life-net/ko/issues/94