Looting item bundle causes the game to crash

ko4life-net / ko

Open source development of the game Knight Online. This is a reversed engineered old version of the game aiming to replicate the nostalgic experience we all once had <3

MIT License

52 stars 21 forks source link

Looting item bundle causes the game to crash #135

Closed stevewgr closed 1 year ago

stevewgr commented 1 year ago

Description

Looting item bundle causes the game to crash.

Official behavior always provide at least one item, which is coins.

To Reproduce

Kill a monster
Try to loot item

Client will crash.

Tasks

[x] Check whether packet receive or send works correctly, if yes, enforce the default first item to always be coins.

xGuTeK commented 1 year ago

I have fixed this issue already it will be pulled in my next PR

stevewgr commented 1 year ago

Still pending for a PR. The fix though is simple; changing item table ext constant to 23, but given that @xGuTeK already fixed it, let's wait for his PR.

stevewgr commented 1 year ago

This issue was fixed in this PR by @srmeier: https://github.com/ko4life-net/ko/pull/174