Open source development of the game Knight Online. This is a reversed engineered old version of the game aiming to replicate the nostalgic experience we all once had <3
MIT License
52
stars
21
forks
source link
Increasing `MAX_ITEM_EXTENSION` to read in table 23 that is being reference at runtime. #174
[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the canary branch (left side). Also you should start your branch off our canary.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
Description
After starting a Karus character one of the first things I did was kill and try to loot a Kecoon Scout. When trying to loot the monster I hit the following issue with a NULL pointer due to a missing s_pTbl_Items_Exts entry. Since the Item Extension 23 TBL is already present in the game assets I propose increasing the MAX_ITEM_EXTENSION variable to 23 in order to address the issue.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
After starting a Karus character one of the first things I did was kill and try to loot a Kecoon Scout. When trying to loot the monster I hit the following issue with a NULL pointer due to a missing
s_pTbl_Items_Extsentry. Since the Item Extension 23 TBL is already present in the game assets I propose increasing theMAX_ITEM_EXTENSIONvariable to 23 in order to address the issue.💔Thank you!