Cleanup code duplication in UIVarious.

ko4life-net / ko

Open source development of the game Knight Online. This is a reversed engineered old version of the game aiming to replicate the nostalgic experience we all once had <3

https://github.com/ko4life-net/ko

MIT License

55 stars 22 forks source link

Cleanup code duplication in UIVarious. #185

Closed stevewgr closed 1 year ago

stevewgr commented 1 year ago

Description

This PR cleanup nonsense amount of code duplication in UIVarious.

Also encourage mode modern C++ to avoid vulnerable usages of sprintf by including the relevant headers in the precompiled header.

Cleanup sprintf usages and local buffer.
Use CN3UIString::SetStringAsInt instead of casting it in the caller.