search

ko4life-net / ko

Open source development of the game Knight Online. This is a reversed engineered old version of the game aiming to replicate the nostalgic experience we all once had <3
MIT License
54 stars 21 forks source link

Saving character data when exiting the game. #200

Closed selcukcukur closed 1 year ago

selcukcukur commented 1 year ago

Character data is treated as binary in some parts and char in some parts, this pull request allows it to save normal character data. Character's level, exp, race score, etc. It records general information without any problems.

Additional regulations to be added ;

In addition, data types in the database have been corrected : https://github.com/ko4life-net/ko-db/pull/8

NOTE : This withdrawal request also ensures that the items added to or removed from the bank are recorded.

selcukcukur commented 1 year ago

@stevewgr It is now ready to be implemented! 🚀

stevewgr commented 1 year ago

@stevewgr It is now ready to be implemented! 🚀

Thanks for the PR. I can't review it because your editor changed file encoding and the diff is not readable unfortunately. I'll convert this PR to draft to indicate work in progress. Please also reference the ticket for clarity.

selcukcukur commented 1 year ago

@stevewgr There is no problem with the pull request, the character encoding has not been changed, you should check it again.

stevewgr commented 1 year ago

@stevewgr There is no problem with the pull request, the character encoding has not been changed, you should check it again.

Please check your diff (git diff) before submitting a PR. I can't start a review unless the diff is clean.