ko4life-net / ko

Open source development of the game Knight Online. This is a reversed engineered old version of the game aiming to replicate the nostalgic experience we all once had <3

https://github.com/ko4life-net/ko

MIT License

55 stars 22 forks source link

Save data when the character leaves the game. #201

Closed selcukcukur closed 1 year ago

selcukcukur commented 1 year ago

The strItem, strSerial, strSkill columns in character should always be read in binary, this fixes errors in the pull request datatype.

132 - This pull request fixes the issue reported here.

[x] strItem should be read and registered correctly.
[x] strSkill should be read and registered correctly.
[x] strSerial should be read and registered correctly.

Additionally this must be implemented in the pull request. ( https://github.com/ko4life-net/ko-db/pull/9 )

stevewgr commented 1 year ago

Nice, looks good so far. Thank you! Note that you're also resolving this ticket with your changes: https://github.com/ko4life-net/ko/issues/94

I'll test it later just to confirm before merging. However I cannot approve this PR until you fix the ko-db PR: https://github.com/ko4life-net/ko/issues/132

Same comment as I had on the previous PR of yours (you need a migration script): https://github.com/ko4life-net/ko-db/pull/8#issuecomment-1613889647

selcukcukur commented 1 year ago

Nice, looks good so far. Thank you! Note that you're also resolving this ticket with your changes: #94

I'll test it later just to confirm before merging. However I cannot approve this PR until you fix the ko-db PR: #132

Same comment as I had on the previous PR of yours (you need a migration script): ko4life-net/ko-db#8 (comment)

https://github.com/ko4life-net/ko-db/pull/10 👍🏼