ko4life-net / ko

Open source development of the game Knight Online. This is a reversed engineered old version of the game aiming to replicate the nostalgic experience we all once had <3
https://github.com/ko4life-net/ko
MIT License
55 stars 22 forks source link

Load & use DB config in recordsets #226

Closed twostars closed 6 months ago

twostars commented 6 months ago

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

Description

This behaves similarly to official, with the only difference it uses a shared method in CServerDlg (etc.) to construct the connection string from members of CServerDlg (etc.), whereas officially it accesses this externally, e.g.:

CString strConnect;
strConnect.Format(..., m_pMain->m_strGameDSN, ...);

💔Thank you!

stevewgr commented 5 days ago

Looks like some stuff were missed in this PR and I fixed it here for the record: https://github.com/ko4life-net/ko/pull/268

in this commit: https://github.com/ko4life-net/ko/commit/1fa93c7933a12f6003a8ba93cf3cc3b0484e1746