search

ko4life-net / ko

Open source development of the game Knight Online. This is a reversed engineered old version of the game aiming to replicate the nostalgic experience we all once had <3
MIT License
52 stars 21 forks source link

Fix gitattributes file to treat *.rc & *.rc2 files as text #244

Closed stevewgr closed 1 month ago

stevewgr commented 1 month ago

Description

Resolves: https://github.com/ko4life-net/ko/issues/243

Note that the bug in git's code triggers when adding the gitattributes configurations in an individual commit. The changes of gitattributes and renormalization of the affected files must occur within the same commit when modifying the .gitattributes file as described here: https://github.com/git-for-windows/git/issues/5078#issuecomment-2266381771

Moving forward any changes to *.rc and *.rc2 files should properly render the diffs.

Also I explictly set some files as binary in the gitattributes file to hint git to not touch them when checking out files in the git's worktree or git index.

stevewgr commented 1 month ago

Build passing without any issues 🎉: https://github.com/ko4life-net/ko/actions/runs/10225794695/job/28295256832

Merging.