Fixes N3ME, N3FXE, and SkyViewer crash and assertion errors.

ko4life-net / ko

Open source development of the game Knight Online. This is a reversed engineered old version of the game aiming to replicate the nostalgic experience we all once had <3

https://github.com/ko4life-net/ko

MIT License

55 stars 22 forks source link

Fixes N3ME, N3FXE, and SkyViewer crash and assertion errors. #255

Closed stevewgr closed 2 weeks ago

stevewgr commented 2 weeks ago

Description

This pull request addresses stability issues in N3ME, N3FXE, and SkyViewer by adding necessary safeguards and corrections for object handling.

N3ME: Fixed a crash on CMainFrame::OnDestroy by adding checks to ensure that CSliderCtrl handles are valid before accessing positions.
N3FXE and SkyViewer: Corrected dummy object loading to use existing objects, preventing assertion errors that occurred in debug builds.

stevewgr commented 2 weeks ago

Build passing: https://github.com/ko4life-net/ko/actions/runs/11789574693

Merging.