feat: set name of middleware function to improve interop with monitoring tools

satazor commented 8 months ago

Set name of middleware function to improve interop with monitoring tools.

Tools like @opentelemetry/instrumentation-koa use function names to generate span names. These names appear in UI of monitoring tools, such as datadog.

Because the returned function doesn't have a name, there's no hint about the actual middleware associated with that span. See below:

In v4 the returned middleware had a name but in v5 got removed, see: https://github.com/koajs/bodyparser/blob/5678a79e64d7833e0dd7734c9e9de40126e14d98/index.js#L63.

Checklist

[x] I have ensured my pull request is not behind the main or master branch of the original repository.
[x] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
[x] I have written a commit message that passes commitlint linting.
[x] I have ensured that my code changes pass linting tests.
[x] I have ensured that my code changes pass unit tests.
[x] I have described my pull request and the reasons for code changes along with context if necessary.

fengmk2 commented 8 months ago

@koa/bodyparser@5.1.0

satazor commented 8 months ago

@fengmk2 thanks for the quick merge and release 🙏

koajs / bodyparser

feat: set name of middleware function to improve interop with monitoring tools #159

Checklist