fix: support Koa2 / Node 6.2

koajs / cors

Cross-Origin Resource Sharing(CORS) for koa

Other

732 stars 80 forks source link

fix: support Koa2 / Node 6.2 #20

Closed leecade closed 4 years ago

leecade commented 8 years ago

fixes #18

codecov-io commented 8 years ago

Current coverage is 98.11%

Merging #20 into v2.x will decrease coverage by 1.88%

@@               v2.x        #20   diff @@
==========================================
  Files             1          1          
  Lines            53         53          
  Methods           3          3          
  Messages          0          0          
  Branches         19         20     +1   
==========================================
- Hits             53         52     -1   
- Misses            0          1     +1   
  Partials          0          0

Powered by Codecov. Last updated by a62232d...9691dec

fengmk2 commented 8 years ago

@leecade ci test fail

gabzim commented 7 years ago

can this be rebased and merged?

RobertHerhold commented 7 years ago

What's the status of this? @fengmk2

fengmk2 commented 7 years ago

@leecade should rebase and add a test case for this change.

luisfarzati commented 5 years ago

I think this PR can be closed since Node 6 support was just dropped since 3.0.0.

dead-horse commented 4 years ago

close for now, seems it is not a fix for this problem. :(