append Vary Header when Access-Allow-Origin is not *.

koajs / cors

Cross-Origin Resource Sharing(CORS) for koa

Other

732 stars 82 forks source link

append Vary Header when Access-Allow-Origin is not *. #25

Closed iyuq closed 7 years ago

iyuq commented 7 years ago

append Vary Header Access-Allow-Origin when Access-Allow-Origin is not *.

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #25 into v2.x will not change coverage

@@           v2.x   #25   diff @@
=================================
  Files         1     1          
  Lines        53    57     +4   
  Methods       3     3          
  Messages      0     0          
  Branches     19    21     +2   
=================================
+ Hits         53    57     +4   
  Misses        0     0          
  Partials      0     0

Powered by Codecov. Last update cd8fe6d...1dcb7f2

iyuq commented 7 years ago

I should use ctx.vary instead of ctx.append. I will open another pull request to fix this.