koajs / cors

Cross-Origin Resource Sharing(CORS) for koa
Other
732 stars 82 forks source link

Vary: Origin #31

Closed lishengzxc closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #31 into v2.x will not change coverage. The diff coverage is 100%.

@@         Coverage Diff         @@
##           v2.x    #31   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines        53     54    +1     
  Branches     19     19           
===================================
+ Hits         53     54    +1
Impacted Files Coverage Δ
index.js 100% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd8fe6d...c254970. Read the comment docs.

fengmk2 commented 7 years ago

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Vary

fengmk2 commented 7 years ago

Please add the tests for these changes

lishengzxc commented 7 years ago

@fengmk2 done~

fengmk2 commented 7 years ago

2.2.1

fengmk2 commented 7 years ago

@lishengzxc can you patch this change into master?

lishengzxc commented 7 years ago

@fengmk2 only add Vary: Origin for master rather than merge v2.x into master?

fengmk2 commented 7 years ago

@lishengzxc yes.